Correction to diodes.md #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description places the diodes in a Reverse Bias (Cathode on the High side, Anode on the Low side) which would prevent current flow even when the switch is pressed. Columns must be pulled high and rows low to match the diagram and work. Looping columns vs rows first is immaterial, although it could still be rewritten to loop rows first as long as columns are the ones pulled high and not the rows.
Contributor
|
Thank you so much I love the help! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (of the diagram) places the diodes in a Reverse Bias (Cathode on the High side, Anode on the Low side) which would prevent current flow even when the switch is pressed.
Columns must be pulled high and rows low to match the diagram and work. Looping columns or rows first is immaterial as long as columns are the ones pulled high and not the rows to match the diagram.